-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
koord-scheduler: fix gpu name to nvidia/gpu in reservation level event #2073
koord-scheduler: fix gpu name to nvidia/gpu in reservation level event #2073
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2073 +/- ##
=======================================
Coverage 68.63% 68.63%
=======================================
Files 430 430
Lines 39536 39537 +1
=======================================
+ Hits 27136 27138 +2
+ Misses 10058 10057 -1
Partials 2342 2342
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
/lgtm |
Signed-off-by: 佑祎 <zzw261520@alibaba-inc.com>
b008dc1
to
65fa4f8
Compare
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: jasonliu747 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ⅰ. Describe what this PR does
fixed before: 0/5 reservations are available: 4 Reservation(s) Insufficient nvidia, 1 Reservation(s) is unschedulable.
after fix: 0/5 reservations are available: 4 Reservation(s) Insufficient nvidia.com/gpu, 1 Reservation(s) is unschedulable.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test